Add simple where condition to filter on indexed fields #6
Conversation
nwestfall
left a comment
nwestfall
left a comment
There was a problem hiding this comment.
Some of it I have to test, but let me know your thoughts. Love the contribution!
Change the way the filter json object is generated + some small corrections
|
@nwestfall Did you see my updates? |
|
Any news on this? |
|
Sorry for the delay guys, had a few other projects come up. I'm pulling the code and taking a look to try and get this out. |
nwestfall
left a comment
nwestfall
left a comment
There was a problem hiding this comment.
I think just fix the build and this will be good to go. Like the approach you took for theIndexFilterValue
| /// <returns></returns> | ||
| public async Task<IList<TRecord>> Where<TRecord>(string storeName, string indexName, object filterValue) | ||
| { | ||
| var filters = new List<IndexFilterValue>() {new(indexName, filterValue)}; |
There was a problem hiding this comment.
What version of C# is this? I don't think I'm using it yet, but I'm always happy to update this.
There was a problem hiding this comment.
It's a C# 9.0 feature, maybe not ideal to use on a project that target .Net Core 3.1 but it is compatible with.
|
@BenoitLacour never mind, I did not mean to merge this, not sure what happened. But now that it's in master, I can go ahead and fix it. Thanks! |
3 participants
Hello,
This is a proposal to add a simple where filter to filter on indexed fields. I needed it to make an app I work on faster to recover entities linked data.
Maybe I'm wrong and it has already another solution, but didn't find it so this PR could help other users.
Best regards,
Benoît