-
Notifications
You must be signed in to change notification settings - Fork 0
fixes: run targets scoping issues #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request introduces namespace support for tasks, especially when including other runfiles. It also fixes a bug where the runfile path was not being correctly set for tasks. Additionally, it adds tmux to the list of terminals that support ANSI escape codes and removes unused test code. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nxtcoder17 - I've reviewed your changes - here's some feedback:
Overall Comments:
- The changes to
types/context.goandtypes/types.golook good, but it would be helpful to add some comments explaining the purpose of the newTaskNamespacefield. - The changes to
parser/parse-command.golook good, but it would be helpful to add some comments explaining why the task namespace is being prepended to the run target.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Fix task scoping and namespace handling in the runfile parser and runner
Bug Fixes:
Enhancements:
Chores: