fix: sandbox wrapper resolution and global property handling#58
Merged
Conversation
nyariv
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR fixes several sandbox runtime edge cases around function replacement resolution, global access, and compile-time execution context reuse.
Why it changed
A few code paths were still looking up replacements from the shared sandbox context instead of the per-execution
evalsmap, which could lead to inconsistent behavior for wrapped globals and constructors. The branch also tightens own-property checks so inherited properties are not accidentally treated as declared globals or constants.User impact
Users get more consistent behavior when accessing or invoking sandboxed globals such as
Function,AsyncFunction,eval, andRegExp, along with safer property resolution for globals and scopes.Root cause
Replacement factories had effectively moved to execution-scoped state, but some call sites and property access helpers were still reading from the old context-level path. A few
inchecks also allowed prototype-chain matches where own-property checks were intended.Validation
npx jest --runInBand