Skip to content

feat: timetable api returns lesson groups in order to access label#586

Merged
SavioNYJC merged 3 commits into
weeklyfrom
fix/timetable-label-attribute-missing
May 13, 2026
Merged

feat: timetable api returns lesson groups in order to access label#586
SavioNYJC merged 3 commits into
weeklyfrom
fix/timetable-label-attribute-missing

Conversation

@SavioNYJC
Copy link
Copy Markdown

No description provided.

@SavioNYJC
Copy link
Copy Markdown
Author

Note that there is a now a duplicated field for label in TimetableEntry

@ngjunsiang
Copy link
Copy Markdown
Contributor

Hmm I suspect the longer-term fix would be to use the from_storage() classmethod of the model, to avoid having to manually specify fields. Otherwise every schema update will require updating the factory function.

I'll probably only be able to look into it next week after choir concert though.

@SavioNYJC SavioNYJC merged commit c395743 into weekly May 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Label attribute not returned by campus server when timetable is queried

2 participants