fix: address review findings across codebase optimization branch#32
Merged
mqasimca merged 1 commit intochore/codebase-optimizationfrom Mar 8, 2026
Merged
Conversation
Collaborator
mqasimca
commented
Mar 8, 2026
mqasimca
commented
- Add proper type assertion checks with t.Fatal() in MCP proxy tests
- Replace verbose sort comparators with cmp.Compare() one-liners
- Add warning logs on silent cache init error paths in Air server
- Strengthen printTopItems tests to verify output content and ordering
- Fix readLine test to call actual function instead of reimplementation
- Unify GPG non-interactive error markers across test files
- Fix docs: agent count, hook trigger docs, matcher syntax, Go version
- Wrap test-integration-fast in bash pipefail for consistency
- Add proper type assertion checks with t.Fatal() in MCP proxy tests - Replace verbose sort comparators with cmp.Compare() one-liners - Add warning logs on silent cache init error paths in Air server - Strengthen printTopItems tests to verify output content and ordering - Fix readLine test to call actual function instead of reimplementation - Unify GPG non-interactive error markers across test files - Fix docs: agent count, hook trigger docs, matcher syntax, Go version - Wrap test-integration-fast in bash pipefail for consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.