TW-4910: TUI scope mismatch — structured errors, flash safety, q-to-quit#73
Merged
qasim-nylas merged 1 commit intomainfrom May 10, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
insufficient_scopesAPI errors with actionable suggestions (nylas auth show,nylas auth login,nylas auth switch) instead of generic error messages; falls back to human-readable text when the API message is emptyFlashLoadErrorhelper to prevent data races when TUI views flash errors from backgroundLoad()goroutinesq/Qto quit (k9s/less/top convention), guarded in filter mode, command palette, and detail views (compose/forms)APIError.Error()to surface both message and type for better diagnosticsWrapErrorTest plan
go test ./internal/domain/— APIError.Error() all branches + Unwrapgo test ./internal/cli/common/— insufficient_scopes with/empty message, generic 403 fallthrough, 429, 500go test ./internal/tui/ -run TestFlash— deadlock-freedom, pre-run flash visibilitygo test ./internal/tui/ -run TestAppQKey— q/Q stop behaviornylas tui→ verifyqquits, but not during:command mode,/filter, or compose formsDocs