fix(threads): URL-encode thread id in path#318
Conversation
Signed-off-by: SAY-5 <saiasish.cnp@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #318 +/- ##
============================================
- Coverage 82.47% 82.44% -0.03%
- Complexity 357 358 +1
============================================
Files 37 38 +1
Lines 1027 1031 +4
Branches 95 95
============================================
+ Hits 847 850 +3
- Misses 121 122 +1
Partials 59 59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The The |
|
@SAY-5 first of all: thank you for contributing to this repo ❤️ I've just expanded your solution to all of our resources in this SDK, to have uniform solution across the repository for sdk-reference, don't worry about it - it fails because for security reasons token cannot be passed to a fork. it is completely acceptable that this fails, and I do verify every PR :) thanks again! |
Fixes #260. Thread ids containing
/were passed unencoded into the request path, where OkHttp'saddPathSegmentssplits on/and produces a malformed URL. Encode the id withURLEncoder(replacing+with%20so it stays a valid path segment) infind,update, anddestroy.I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.