Migrate exchangeCodeForToken to node-fetch#214
Merged
sdwvit merged 3 commits intonylas:mainfrom Mar 16, 2021
Merged
Conversation
Ref nylas#174 Migrating whole library from "request" at once would be quite massive. In this diff I migrated only exchangeCodeForToken to figure out how to test and install dependencies.
Contributor
Author
|
cc @sdwvit |
sdwvit
reviewed
Jan 21, 2021
| url.searchParams.set('client_id', this.clientId); | ||
| url.searchParams.set('client_secret', this.clientSecret); | ||
| url.searchParams.set('grant_type', 'authorization_code'); | ||
| url.searchParams.set('code', code); |
Contributor
There was a problem hiding this comment.
using URL is an interesting choice here ;) is it just to urlencode querystring? looks good to me, just wanted to point out
Contributor
Author
There was a problem hiding this comment.
Browser support makes it more preferred choice over querystring
sdwvit
reviewed
Jan 21, 2021
| return callback(null, body['access_token']); | ||
| callback(error); | ||
| } | ||
| throw error; |
Contributor
There was a problem hiding this comment.
wouldn't it make sense to recreate an Error so it includes current frame in a stacktrace?
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #174
Migrating whole library from "request" at once would be quite massive.
In this diff I migrated only exchangeCodeForToken to figure out how to
test and install dependencies.
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.