[66695] Refactor Restfulmodel#267
Merged
mrashed-dev merged 5 commits intoSep 3, 2021
Merged
Conversation
Created two new "base" classes called `model` and `model-collection`. These two classes provide a way for creating models that are not the typical Nylas API models (Event, Calendar, etc.) but will still require similar functionality. Also not all models are "RESTful", `Contact.Email` for example does not.
|
This pull request has been linked to Clubhouse Story #66695: Refactor RestfulModel. |
ozsivanov
reviewed
Sep 2, 2021
ozsivanov
reviewed
Sep 2, 2021
ozsivanov
reviewed
Sep 2, 2021
ozsivanov
reviewed
Sep 2, 2021
ozsivanov
reviewed
Sep 2, 2021
Instead of `_[name]` notation
philrenaud
approved these changes
Sep 3, 2021
ozsivanov
approved these changes
Sep 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As the SDK coverage grows, we need to decouple the standard functionality of a model from the specific functionality/structure of a "classic" Nylas API model. A "classic" Nylas API model is a model used for endpoints like
Event,Calendar,Message, etc. where we expect the object to have anid,account_id, andobjectfield. There are a lot of "dumb" models likeContact.Emailsthat would benefit from being cast as a basic model versus the current RestfulModel, as well as having the ability in the future for creating different types of models.License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.