Updating exchange token response to match API#279
Merged
mrashed-dev merged 14 commits intoJan 12, 2022
Merged
Conversation
Contributor
|
Looks good to me! Will be included in the refactor! |
mrashed-dev
changed the base branch from
main
to
mostafarashed/ch66699/release-node-sdk-v6-0-0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.shortcut.com/nylas/story/69505/nylas-exchangecodefortoken-response-body-doesn-t-match-the-api-response
A customer noticed that we were returning only the access token in the exchange token response. This doesn't match the API's response so I updated the response body to include the full response body from the call we make to exchange the token. This will return identifying information about the account as well.
https://developer.nylas.com/docs/api/#post/oauth/token
{
access_token: string
account_id: string
email_address: string
provider: enum
token_type: string
}
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.