[v6.0 Refactor] Pre-QA Bug Fixes#284
Merged
mrashed-dev merged 20 commits intoOct 29, 2021
Merged
Conversation
The conditional logic in the RestfulModel toJSON method was not explicit enough on the value of enforceReadOnly, leading to JSON.stringify unintentionally ignoring read only values.
Updated readme links and removed pages that don't exist anymore
…272) JSON.parse(req.rawBody) was throwing an error if req.rawBody was an empty string.
This PR addresses an issue that causes some PUT calls for Calendar objects to break. The issue was found when a customer was unable to update an event on API 2.2 with the API rejecting the call because message_id was present in the body. The messageId property is supposed to be readonly. We have 5 properties in Calendar that are now marked as readonly: messageId, owner, iCalUID, status, and jobStatusId
This PR enables support for the /calendars/availability/consecutive endpoint.
New nylas v5.8.0 release
This PR enables SDK support for the Scheduler API.
This PR enables SDK support for the Nylas /component endpoints.
* Update CHANGELOG.md * 5.9.0
Some variables were being compiled with the type `never[]` because of the way it was being initialized without specifying a type.
- Created model to represent calendar availability - Updated test cases to reflect standardized camelCase - Update code to match the rest of the refactor
- Created models where appropriate - Fixed tests to align with how we initialize models now
- Created a type that can be used to create a Component object - Moved back to using `path()` function to represent a `RestfulModelCollection` to allow for seamless overriding - Fix tests to reflect changes
`data` isn't a valid API attribute, but is needed to populate data needed to be uploaded
mrashed-dev
changed the base branch from
main
to
mostafarashed/ch66699/release-node-sdk-v6-0-0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR represents a few bug fixes I found during some testing I did myself, as well as porting in all the features from the latest v5.9.0 release, ensuring that all the latest features are in and ready for testing.
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.