[73533] Support remaining Scheduler endpoints#287
Merged
mrashed-dev merged 15 commits intomainfrom Nov 18, 2021
Merged
Conversation
|
This pull request has been linked to Shortcut Story #73533: Support remaining Scheduler API endpoints. |
- Add a new type representing the upload image API response - Add a new class representing the calendars response, and desearlize list of calendars into list of calendar objects
The baseurl previously was modified at the NylasConnection level, which unless cloned, causes problems for subsequent non-scheduler calls. Instead of overwriting it there, pass in a baseUrl option that will override the base url when needed.
…eduler-api-endpoints
tbadun
approved these changes
Nov 17, 2021
tbadun
left a comment
There was a problem hiding this comment.
can't attest to javascript but endpoint stuff looks good :)
Change SchedulerTimeslot => SchedulerBookingRequest and SchedulerSlot => SchedulerTimeslot to avoid confusion
ozsivanov
reviewed
Nov 18, 2021
| name?: string; | ||
| } | ||
| SchedulerAvailableCalendars.collectionName = 'scheduler_available_calendars'; | ||
| SchedulerAvailableCalendars.attributes = { |
There was a problem hiding this comment.
Can these props be set directly in the class declaration?
Contributor
Author
There was a problem hiding this comment.
Unfortunately, no. Not in the SDK's current state at least, moving it into the class deceleration leads to a rabbit hole of TS errors.
ozsivanov
approved these changes
Nov 18, 2021
ozsivanov
left a comment
There was a problem hiding this comment.
LGTM - just had a comment about a tiny potential improvement.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the remaining Scheduler endpoints
Usage
Checking Provider Availability
Retrieve available time slots
Book a time slot
Confirm a booking
Cancel a booking
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.