[77455] Prevent Event from sending empty notification array when notifications were not set#298
Merged
mrashed-dev merged 4 commits intoJan 4, 2022
Conversation
Sending an empty event for certain events like recurring events will cause an API error, so unless explicitly set do not sent the notification object
|
This pull request has been linked to Shortcut Story #77455: Prevent sending empty Notification array for Events when notifications are not set. |
philrenaud
approved these changes
Jan 4, 2022
mrashed-dev
deleted the
mostafarashed/sc-77455/prevent-sending-empty-notification-array
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some recurring events throw an error from the API when sending an empty list of notifications. This could occur without the user setting an empty list of notifications as the Node SDK defaults all array-type attributes to an empty array even if not directly set the attribute. This PR overrides this functionality and prevents
notificationsfrom being set if the user did not explicitly set the attribute.License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.