[78923] Fix saveRequestBody() for Model class#309
Merged
mrashed-dev merged 5 commits intoJan 19, 2022
Merged
Conversation
If we don't move it, then properties of Model type will not serialize for the API properly as it would ignore the `readOnly` property
|
This pull request has been linked to Shortcut Story #78923: Fix logic with saving request body for Model types. |
mrashed-dev
requested review from
a team,
arjunkalburgi and
ozsivanov
and removed request for
a team
ozsivanov
approved these changes
Jan 19, 2022
mrashed-dev
deleted the
mostafarashed/sc-78923/fix-logic-with-saving-request-body-for-model
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
saveRequestBody()was introduced prior to the v6.0 release to enforce read-only attributes not being serialized for outgoing API calls. With the introduction of theModelsuperclass in v6.0 a lot of objects got refactored from extendingRestfulModeltoModel, butsaveRequestBody()remained onRestfulModel. This broke the serialization ofModelproperties. To resolve this, we movedsaveRequestBody()to theModelsuperclass.License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.