Add additional fields for job status webhook notifications#398
Merged
mrashed-dev merged 5 commits intomainfrom Oct 14, 2022
Merged
Conversation
This model is used by job status notifications only
mrashed-dev
requested review from
a team,
AaronDDM and
sourcesoft
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #398 +/- ##
=======================================
Coverage 91.51% 91.52%
=======================================
Files 61 61
Lines 2568 2571 +3
Branches 462 462
=======================================
+ Hits 2350 2353 +3
Misses 217 217
Partials 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mrashed-dev
requested review from
a team,
kgsvg and
theblueskies
and removed request for
a team and
sourcesoft
theblueskies
approved these changes
Oct 14, 2022
mrashed-dev
deleted the
TSDK-490-add-job-status-webhook-fields-to-the-node-sdk
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds additional fields for the webhook notification class. There's also a new model,
WebhookObjectExtrasfor extra fields that can appear for job status notifications.License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.