Change config file to match new Flask rules #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The app.config line that was here doesn't work anymore in Flask 2.1. References: pallets/flask#4078 https://flask.palletsprojects.com/en/2.1.x/changes/ This change must be added with the config file I'm adding next.
Changing file to match with the change in the server.py code
mrashed-dev
approved these changes
Jun 6, 2022
Contributor
mrashed-dev
left a comment
mrashed-dev
left a comment
There was a problem hiding this comment.
Looks good to me @erikkai! Just need to fix the formatting and it will be good to go 👍
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Flask 2.1 onwards the method used to set up the config file is no longer available. So it will break. I replaced it with the config option where you load from a file. Then I set up config.json to be config.py so that it will work.
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.