feat(post): add tag list component to header #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a tag list component to the post header. The changes include:
- New CSS styles for the tag list container and individual tags in styles.css.ts.
- Updated the Header component to accept a new "tags" prop and render a list of tags.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/app/posts/[slug]/_components/header/styles.css.ts | Adds styles to display the tag list and individual tag styling. |
| src/app/posts/[slug]/_components/header/index.tsx | Updates the Header component to accept a "tags" prop and renders a tag list using the new styles. |
| import * as styles from './styles.css'; | ||
|
|
||
| export const Header = ({ coverImage, coverBlur, title, subtitle, createdAt, category }: Post) => { | ||
| export const Header = ({ coverImage, coverBlur, title, subtitle, createdAt, category,tags }: Post) => { |
There was a problem hiding this comment.
[nitpick] Consider adding a space after the comma between 'category' and 'tags' for consistency with the rest of the parameter list.
Suggested change
| export const Header = ({ coverImage, coverBlur, title, subtitle, createdAt, category,tags }: Post) => { | |
| export const Header = ({ coverImage, coverBlur, title, subtitle, createdAt, category, tags }: Post) => { |
ohprettyhak
added a commit
that referenced
this pull request
Apr 21, 2025
* feat: add Next.js files * feat: add eslint and prettier configs * build: add contentlayer mdx build system * feat: integrate `vanilla-extract` and implement theme mode with app layout support (#4) * build: add vanilla-extract dependencies * feat: add site metadata and icons * feat: add theme mode and app layout component * chore: apply suggestions from code review * feat: add profile cards and post grid components to the home page (#6) * feat: add profile cards * Update src/app/page.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix(contentlayer): resolve sync issue and load latest content * feat: add icon components * feat(contentlayer): support both relative paths and URLs for image handling * feat(mainpage): add time display to post grid * fix: move getSortedPosts above usage to prevent runtime error --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat(animation): add page transition animations (#7) * style(contentlayer): add custom styles and code highlighting for MDX content (#9) * feat: add h2, h3, h4, h5, h6, list, p tag styles * style(mdx): change li before color * build: add rehype and remark dependencies * Update src/components/ui/mdx-component/styles.css.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat(posts): implement list page with pagination and configure `copy-webpack-plugin` for SSG build (#10) * feat: add posts page * feat(posts): add pagination and configure copy-webpack-plugin for SSG build * �ci(workflows): add `labeler` workflow for automatic PR labeling (#11) * ci(workflows): add labeler workflow * fix(ci): update labeler permissions * fix(ci): update labeler permissions * fix(ci): remove concurrency option * fix(ci): update labeler on options * fix(ci): update labeler on options * feat(ci): add checkout job to labeler * fix(ci): update labeler config and workflows * fix(ci): fix v2 option labeler config * fix(ci): change working timing * feat(ci): add concurrency option to labeler workflow * feat(ci): add target branch and remove checkout action * feat(post): structure post page with new components and client-side relative time (#12) * feat: add post page header * feat(post): add back button, footer and recommend components * docs: add `2025-04-20-deploy-with-actions` and fix back button component (#13) * docs: add mdx and fix back button * feat: add cover image props * fix(posts): sort posts before rendering * chore(labeler): add documentation label for content folder and sort rules alphabetically * ci(build): add GitHub Actions workflow for automated deployment (#14) * ci: add build workflow * fix(ci): fix deloy 403 error * chore(ci): change push branch * fix(theme): update theme configuration using next-themes * test(build): change deploy push branch * chore(config): test base path config * fix(config): change to empty string * feat(posts): add categories and tags pages for post navigation (#15) * feat: add categories and tags list pages * feat: add url slugify * feat: add categories and tags index pages * Update src/app/categories/[category]/p/[page]/page.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix(build): resolve async issue causing build failure on categories/p and tags/p pages * feat(post): add tag list component to header (#16) * feat: add tag list to post header component * chore: add route constants * ci(build): change deploy push branch * build: add husky and lint-staged (#17) --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.