Support for publishing multiple specs from a directory#8
Support for publishing multiple specs from a directory#8tonglil merged 23 commits intonytimes:mainfrom
Conversation
There was a problem hiding this comment.
Thanks for submitting!
While I don't particularly like overwriting vargs.Spec for each file, it's acceptable.
Other than the comments, can you add some usage/docs in the README?
We probably need to setup some CI for this as well.
ATM this project is only maintained with volunteered time.
|
@tonglil , thanks a lot for the review! I have made those changes, and added a unit test for the code in main.go. Happy to help build out a CI for this repo, if I you can activate this repo in drone (I don't have the needed access) |
|
@tonglil : appreciate a re-review when you get a chance. Also happy to QA this in one of our repos, if this plugin can be pushed with a specific tag before an official release. Thanks! |
4bc4560 to
2a6ee37
Compare
Adds an [optional] parameter
specs_dirto the step. If provided, the code scans through all files in the given directory and pushes them one by one.We have a monorepo that has several yamls, and it is tedious to add a step each time a new spec is created. See here
Need help verifying, is it possible to push the image with a tag, so that I can try it out from our repo?
Closes #5.