Skip to content

docs: Update coordinate systems documentation#40

Merged
ChristopherRabotin merged 2 commits into
masterfrom
update-coord-systems-docs-13169410699226993283
Apr 19, 2026
Merged

docs: Update coordinate systems documentation#40
ChristopherRabotin merged 2 commits into
masterfrom
update-coord-systems-docs-13169410699226993283

Conversation

@ChristopherRabotin
Copy link
Copy Markdown
Member

This PR updates the coordinate systems documentation to mention that the VNC frame is also referred to as the TCN frame in ODTK/STK. It also adds an admonition box at the top of the page to encourage users to try out the ANISE, hifitime, and Nyx libraries.


PR created automatically by Jules for task 13169410699226993283 started by @ChristopherRabotin

- Added note that VNC frame is referred to as TCN in ODTK/STK
- Added callout to promote ANISE, hifitime, and Nyx libraries

Co-authored-by: ChristopherRabotin <4823784+ChristopherRabotin@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 19, 2026

Visit the preview URL for this PR (updated for commit d1ca9ef):

https://nyx-space--pr40-update-coord-systems-asrepska.web.app

(expires Sun, 26 Apr 2026 06:12:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ecf6068ed4b2d3d429c02e3ebe5890356e4315eb

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a promotional tip box to the coordinate systems documentation highlighting the availability of these frames in ANISE, Nyx, and hifitime, and updates the VNC frame description to include its TCN designation in ODTK and STK. The review feedback suggests improving the grammar and relative link paths in the new tip box, as well as refining the phrasing of the VNC frame description for better conciseness.

Comment thread docs/nyxspace/MathSpec/celestial/coord_systems.md Outdated
Comment thread docs/nyxspace/MathSpec/celestial/coord_systems.md Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@ChristopherRabotin ChristopherRabotin merged commit 2470ca9 into master Apr 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant