[connected-solid] Get root container from storage description resource#136
Merged
jaxoncreed merged 4 commits intoo-development:mainfrom Mar 25, 2026
Merged
Conversation
mrkvon
changed the title
mrkvon
force-pushed
the
fix-17-root-from-storage-description
branch
from
acb5db8 to
306bc77
Compare
mrkvon
force-pushed
the
fix-17-root-from-storage-description
branch
from
406b800 to
4f93323
Compare
jaxoncreed
requested changes
Mar 17, 2026
Contributor
jaxoncreed
left a comment
jaxoncreed
left a comment
There was a problem hiding this comment.
Great work. I like the idea of splitting into the two getRootContainerByTraversal and getRootContainerFromStorageDescription.
Though, you commented a TODO referencing caching, and I gave a comment on how to implement it.
packages/connected-solid/src/requester/requests/getStorageDescription.ts
Outdated
Show resolved
Hide resolved
packages/connected-solid/src/requester/requests/getStorageDescription.ts
Outdated
Show resolved
Hide resolved
mrkvon
commented
Mar 18, 2026
packages/connected-solid/src/requester/requests/getStorageDescription.ts
Outdated
Show resolved
Hide resolved
packages/connected-solid/src/requester/requests/getStorageDescription.ts
Outdated
Show resolved
Hide resolved
packages/connected-solid/src/requester/requests/getStorageDescription.ts
Outdated
Show resolved
Hide resolved
mrkvon
force-pushed
the
fix-17-root-from-storage-description
branch
4 times, most recently
from
dbd8c15 to
3271d97
Compare
- cache storage description uri for each resource - cache root container from storage description of each resource Also add comments.
Co-authored-by: jaxoncreed <jaxoncreed@gmail.com>
Also: - fix test - add note to jsdoc about preferring generic getRootContainer
mrkvon
force-pushed
the
fix-17-root-from-storage-description
branch
from
3271d97 to
7670891
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on Solid protocol: https://solidproject.org/TR/protocol#server-storage-description-resource
resource.getRootContainer()tries to discover root storage from storage description resource. If that fails, it falls back to discovery by parent container traversal.Also submethods have been added:
resource.getRootContainerByTraversal()- the original methodresource.getRootContainerFromStorageDescription()- the new featureI recommend hiding whitespaces when reviewing (especially tests), because multiple tests have been nested into additional describe, otherwise unchanged.
TODO:
Fixes #17