transaction logic: fix missing account updates when prevalidating tra… #1025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkuehr
force-pushed
the
transaction_pool_fix
branch
from
ef1a874 to
5de2d76
Compare
|
@sebastiencs can you think of any other cases in which the call forest abstraction was being bypassed? (for this specific check I only found two, which are exactly the ones @dkuehr fixed in this PR) |
|
Yes I didn't find any other cases than those 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the pre-validation function used by the transaction pool.
We were checking top-level account updates and missing the call lists.
Note: the bug was found with differential fuzzing against the OCaml implementation.