fix(node): Fix zero value for the empty coinbase stack data hash #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastiencs
reviewed
May 9, 2024
| } | ||
|
|
||
| impl CoinbaseStackData { | ||
| pub fn zero() -> Self { |
Contributor
There was a problem hiding this comment.
@tizoc That method should probably be renamed to empty ? To make it clear that it's value is not zero
Collaborator
Author
There was a problem hiding this comment.
(and same for the callers which are currently named zero too)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing the genesis protocol state hash to be computed incorrectly.