Skip to content

tweak: Rename zero methods to empty #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2024
Merged

tweak: Rename zero methods to empty #391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/block/genesis.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ fn blockchain_state(
let stmt_registers = v2::MinaStateBlockchainStateValueStableV2LedgerProofStatementSource {
first_pass_ledger: genesis_ledger_hash.clone(),
second_pass_ledger: genesis_ledger_hash.clone(),
pending_coinbase_stack: v2::MinaBasePendingCoinbaseStackVersionedStableV1::zero(),
pending_coinbase_stack: v2::MinaBasePendingCoinbaseStackVersionedStableV1::empty(),
local_state: empty_local_state,
};
let empty_fee_excess = v2::TokenFeeExcess {
Expand Down
6 changes: 3 additions & 3 deletions mina-p2p-messages/src/v2/manual.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ impl EpochSeed {
}

impl CoinbaseStackData {
pub fn zero() -> Self {
pub fn empty() -> Self {
// In OCaml: https://github.com/MinaProtocol/mina/blob/68b49fdaafabed0f2cd400c4c69f91e81db681e7/src/lib/mina_base/pending_coinbase.ml#L186
// let empty = Random_oracle.salt "CoinbaseStack" |> Random_oracle.digest
let empty = super::hash_noinputs("CoinbaseStack");
Expand Down Expand Up @@ -320,9 +320,9 @@ impl super::MinaBasePendingCoinbaseUpdateStableV1 {
}

impl super::MinaBasePendingCoinbaseStackVersionedStableV1 {
pub fn zero() -> Self {
pub fn empty() -> Self {
Self {
data: CoinbaseStackData::zero(),
data: CoinbaseStackData::empty(),
state: super::MinaBasePendingCoinbaseStateStackStableV1 {
init: CoinbaseStackHash::zero(),
curr: CoinbaseStackHash::zero(),
Expand Down