Skip to content

Conversation

@0xMimir
Copy link
Contributor

@0xMimir 0xMimir commented Jul 16, 2024

Fixes #543, added Token::Handshake in data sent when negotiating multiplexing protocol.

If handshake is not sent with multiplexing protocol during negoation with OCaml node, OCaml node throws error when trying to dial rust node in go-multistream@v0.3.3/client.go:

func readMultistreamHeader(r io.Reader) error {
	tok, err := ReadNextToken(r)
	if err != nil {
		return err
	}

	if tok != ProtocolID {
		return errors.New("received mismatch in protocol id")
	}
	return nil
}

With error: received mismatch in protocol id

@0xMimir 0xMimir changed the title Added handshake for Yamux token Added handshake in data sent during multiplex negotiation Jul 16, 2024
@0xMimir 0xMimir force-pushed the bugfix/ocaml-not-connecting branch from 8434bfd to 4918338 Compare July 16, 2024 18:59
@0xMimir 0xMimir requested a review from vlad9486 July 16, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants