Conversation
…AnkitSiva Signed-off-by: wrigleyDan <dwrigley@opensourceconnections.com>
…onse_hit_ids to request schema as suggested in o19s#33 Signed-off-by: wrigleyDan <dwrigley@opensourceconnections.com>
Signed-off-by: wrigleyDan <dwrigley@opensourceconnections.com>
…es PR o19s#37 obsolete. Signed-off-by: wrigleyDan <dwrigley@opensourceconnections.com>
|
After reviewing the changes in the JSON schema files the docs need to be generated as a final step. |
epugh
left a comment
There was a problem hiding this comment.
LGTM, and you even got the manual date updating taken care of ;-)
|
This looks great, and I think you can merge it. Did you notice any steps that need to be updated in https://github.com/o19s/ubi/blob/main/DEVELOPMENT.md#to-release-ubi ??? |
Generally, the steps are alright. They might benefit from some polishing:
I'd be happy to take of that. when generating the html docs for the 1.3.0 release. Is that a separate PR or do we handle that in this PR? |
|
I think hte polish can be it's own PR, as I'd like to get 1.3 to done, so that can go anytime.. |
Signed-off-by: wrigleyDan <dwrigley@opensourceconnections.com>
Signed-off-by: wrigleyDan <dwrigley@opensourceconnections.com>
Signed-off-by: wrigleyDan <dwrigley@opensourceconnections.com>
This PR pulls together the changes for UBI specification version 1.3.0.
Issues resolved:
user_queryas optional attribute to the Events Schema #35: adduser_queryto events schemaquery_response_hit_idsto query request schemaindexproperty from events schema for tracking positional informationclick_throughfrom enums in events schemaSince working on schemas requires changes in JSON and documentation files it's not trivial to merge all PRs one by one, so this PR replaces several to make the changes for the new version go smoothly: