Skip to content

UBI Specification 1.3.0 Branch#38

Merged
wrigleyDan merged 7 commits intoo19s:mainfrom
wrigleyDan:ubi-spec-130
Feb 26, 2025
Merged

UBI Specification 1.3.0 Branch#38
wrigleyDan merged 7 commits intoo19s:mainfrom
wrigleyDan:ubi-spec-130

Conversation

@wrigleyDan
Copy link
Collaborator

@wrigleyDan wrigleyDan commented Feb 26, 2025

This PR pulls together the changes for UBI specification version 1.3.0.

Issues resolved:

Since working on schemas requires changes in JSON and documentation files it's not trivial to merge all PRs one by one, so this PR replaces several to make the changes for the new version go smoothly:

…AnkitSiva

Signed-off-by: wrigleyDan <dwrigley@opensourceconnections.com>
…onse_hit_ids to request schema as suggested in o19s#33

Signed-off-by: wrigleyDan <dwrigley@opensourceconnections.com>
Signed-off-by: wrigleyDan <dwrigley@opensourceconnections.com>
…es PR o19s#37 obsolete.

Signed-off-by: wrigleyDan <dwrigley@opensourceconnections.com>
@wrigleyDan
Copy link
Collaborator Author

After reviewing the changes in the JSON schema files the docs need to be generated as a final step.

Copy link
Member

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and you even got the manual date updating taken care of ;-)

@epugh
Copy link
Member

epugh commented Feb 26, 2025

This looks great, and I think you can merge it. Did you notice any steps that need to be updated in https://github.com/o19s/ubi/blob/main/DEVELOPMENT.md#to-release-ubi ???

@wrigleyDan
Copy link
Collaborator Author

Did you notice any steps that need to be updated in https://github.com/o19s/ubi/blob/main/DEVELOPMENT.md#to-release-ubi ???

Generally, the steps are alright.

They might benefit from some polishing:

  • Format all folders, filenames, file extensions as code
  • Use a Python environment to install the Python lib and generate the html docs; that way we could get rid of your local file system reference /Users/epugh/.asdf/...
  • Remove the link https://o19s.github.io/blob/main/docs/ - it points to no existing resource

I'd be happy to take of that. when generating the html docs for the 1.3.0 release. Is that a separate PR or do we handle that in this PR?

@epugh
Copy link
Member

epugh commented Feb 26, 2025

I think hte polish can be it's own PR, as I'd like to get 1.3 to done, so that can go anytime..

Signed-off-by: wrigleyDan <dwrigley@opensourceconnections.com>
Signed-off-by: wrigleyDan <dwrigley@opensourceconnections.com>
Signed-off-by: wrigleyDan <dwrigley@opensourceconnections.com>
@wrigleyDan wrigleyDan added this to the 1.3 milestone Feb 26, 2025
@wrigleyDan wrigleyDan merged commit 821b4f0 into o19s:main Feb 26, 2025
@wrigleyDan wrigleyDan deleted the ubi-spec-130 branch February 26, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

invalid use of oneOf

2 participants