Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
…for dxp starter and mocked data
WalkthroughThe project scaffolding cleanup process is refactored. ALWAYS_REMOVE_DIRS constant is expanded to include packages/blocks and packages/integrations. The cleanupProject function is simplified—its signature changed to accept only projectDir, removing dependencies on user-selected block and integration names. Package.json transformation logic is extended to process both dependencies and devDependencies, filtering out private workspace packages and unselected dependencies. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/cli/create-o2s-app/src/constants.ts (1)
18-20: Consider using existing constants for consistency.The values
'packages/blocks'and'packages/integrations'are duplicated withBLOCKS_PATHandINTEGRATIONS_PATHdefined at lines 9-10. Using those constants inALWAYS_REMOVE_DIRSwould improve maintainability.♻️ Suggested refactor
export const ALWAYS_REMOVE_DIRS: string[] = [ '.git', '.github', '.changeset', 'apps/docs', - 'packages/blocks', + BLOCKS_PATH, 'packages/framework', - 'packages/integrations', + INTEGRATIONS_PATH, 'packages/modules', 'packages/utils', 'packages/cli', 'packages/telemetry', ];🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/cli/create-o2s-app/src/constants.ts` around lines 18 - 20, ALWAYS_REMOVE_DIRS currently duplicates string literals; update it to use the existing constants BLOCKS_PATH and INTEGRATIONS_PATH instead of hard-coded 'packages/blocks' and 'packages/integrations'. Locate the ALWAYS_REMOVE_DIRS array and replace those two entries with the constants BLOCKS_PATH and INTEGRATIONS_PATH (ensuring they are defined above or imported in this file) so the values remain single-source-of-truth.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/cli/create-o2s-app/src/constants.ts`:
- Around line 18-20: ALWAYS_REMOVE_DIRS currently duplicates string literals;
update it to use the existing constants BLOCKS_PATH and INTEGRATIONS_PATH
instead of hard-coded 'packages/blocks' and 'packages/integrations'. Locate the
ALWAYS_REMOVE_DIRS array and replace those two entries with the constants
BLOCKS_PATH and INTEGRATIONS_PATH (ensuring they are defined above or imported
in this file) so the values remain single-source-of-truth.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c796a11c-ff33-4473-8d41-84bda0029d0f
📒 Files selected for processing (6)
.changeset/afraid-cooks-battle.mdpackages/cli/create-o2s-app/src/constants.tspackages/cli/create-o2s-app/src/scaffold/cleanup.tspackages/cli/create-o2s-app/src/scaffold/index.tspackages/cli/create-o2s-app/src/scaffold/transform-apps-package-json.tspackages/cli/create-o2s-app/src/scaffold/transform-integration-configs.ts
Coverage Report for packages/configs/vitest-config
File CoverageNo changed files found. |
What does this PR do?
Related Ticket(s)
Key Changes
How to test
Media (Loom or gif)
Summary by CodeRabbit
Bug Fixes
Refactor