OneFetch 2.13.2 DisplayVersion written with "v"

[russellbanks]

Duplicates

• I have searched the existing issues

Current behavior 😯

OneFetch 2.13.2 writes the DisplayVersion of v2.13.2. This should really be 2.13.2. This causes WinGet to show OneFetch as always needing an update:

Expected behavior 🤔

OneFetch should write the DisplayVersion without the "v".

Steps to reproduce 🕹

1. Install OneFetch 2.13.2.
2. See DisplayVersion written with "v" in front of it.

Temporary solution

As a temporary solution, I can add an entry to the Onefetch manifest, and this would tell WinGet to match the manifest to that DisplayVersion:

AppsAndFeaturesEntries:
- DisplayVersion: v2.13.2

Going forward, however, it would be best to remove the "v" from the DisplayVersion.

[russellbanks]

• Update: o2sh.onefetch version 2.13.2 microsoft/winget-pkgs#89274

This has told WinGet to match Onefetch 2.13.2 to the DisplayVersion v2.13.2.

[spenserblack]

Perhaps this issue should be raised with the winget-releaser action? Should it trim the leading v?

[russellbanks]

Perhaps this issue should be raised with the winget-releaser action? Should it trim the leading v?

WinGet Releaser does do this, which is why the manifest that it produces has 2.13.2 as the PackageVersion (A manifest can't/shouldn't start with 'v' in its version).

WinGet Releaser can't change what is written to registry, though, so WinGet will match the PackageVersion from the manifest to the DisplayVersion, meaning it will always see it as a new version:

• 2.13.2 (PackageVersion) > v2.13.2 (DisplayVersion in registry)

[o2sh]

Thanks a lot for reporting this issue @russellbanks and for the PR with the temporary fix 👍

As for the definite solution, I see two options:

• Update the Makefile, so that the version name that is passed to the installer template doesn't contain the letter "v"
• Drop the "v" in our naming convention alltogether: next version will be 2.14.0 instead of v2.14.0

[russellbanks]

I think updating the Makefile would be sufficient. Having v2.13.2 as the GitHub release is perfectly fine, but in terms of general DisplayVersion naming conventions, OneFetch does stick out a little bit having the "v" (screenshot of some versions in my Control Panel):

The same also goes for the DisplayName (onefetch version v2.13.2) too. This wouldn't cause problems, but as a general naming convention, applications that have the version in the name don't have the "v" there either (LibreOffice as an example):

As a side note, having a DisplayName that isn't consistent between releases isn't necessarily an issue, but it means that this would have to be manually updated in the manifest that is submitted to winget-pkgs each time (mods may request this), as manifest creation tools don't update ARP Entries (they would have to install the program and get the registry keys to do that - potentially something that would be implemented in the future). The ARP Entry for the DisplayName could be removed, but the reason it's there in the first place is to help WinGet match the manifest to the registry keys correctly.

[russellbanks]

Resolved in 2.14.0/2.14.1 :)