Turn AsciiArt.rs into its own crate
#934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
spenserblack
left a comment
spenserblack
left a comment
There was a problem hiding this comment.
Looks like ascii/README.md is an empty file. Should it be a symlink?
Owner
Author
Sorry about that, It wasn't ready, I forgot to mark it as a draft 😓 I added a very short readme. Even though the code is quite clear, this crate is lacking documentation - same applies to |
spenserblack
approved these changes
Jan 18, 2023
Collaborator
spenserblack
left a comment
spenserblack
left a comment
There was a problem hiding this comment.
Even though the code is quite clear, this crate is lacking documentation - same applies to
imageandmanifestBTW.
That gives the community a chance to contribute 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refers to #931