Skip to content

Conversation

@MarkusPettersson98
Copy link

Add support for Crystal repositories. This resolves issue #144.

Love the new language declaration macro, it's super handy! 😄

Hope your Hacktoberfest won't be as spammy as some other repositories. Keep up the great work!

@o2sh
Copy link
Owner

o2sh commented Oct 2, 2020

Hi @MarkusPettersson98, thanks a lot for your PR.

I'm very happy to see that you followed the guidelines concerning the max size of the ascii logo.

However, as most people use terminals with black background. I would advise to maybe interchange the colors: black <-> white.
Even though it means drifting away from the original design of the logo.

Love the new language declaration macro, it's super handy!

Definetely, we have to thank @spenserblack for that 🙏

Increase readability in a black terminal.
@MarkusPettersson98
Copy link
Author

Thank you for the quick response!

I agree that the original color scheme might be hard to read in most terminals, so I swapped black and white in this case.

Screenshot 2020-10-02 at 14 34 10

Dark/light-mode feature incoming? 😉

Thanks! @spenserblack

@o2sh o2sh merged commit 879e57c into o2sh:master Oct 2, 2020
@MarkusPettersson98 MarkusPettersson98 deleted the lang/crystal branch October 2, 2020 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants