Add YAML output (-y) and ISO 8601 date format option (-z) #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spenserblack
requested changes
Jan 10, 2021
Collaborator
spenserblack
left a comment
spenserblack
left a comment
There was a problem hiding this comment.
Overall, LGTM! ❤️ both YAML and ISO 😃
Left a suggestion on the CLI, let me know what you think 🙂
src/onefetch/cli.rs
Outdated
Comment on lines
70
to
74
| .arg( | ||
| Arg::with_name("yaml") | ||
| .short("y") | ||
| .long("yaml") | ||
| .help("Outputs Onefetch in YAML format.") |
Collaborator
There was a problem hiding this comment.
Since this conflicts with the --json flag, I think that either
conflicts_with("json")should be added (and also aconflicts_with("yaml")for the jsonArg), or- The
--jsonand--yamlflags should be replaced with a--formatArgwith the possible valuesjsonandyaml
Personally, I think the latter would be better to keep the CLI as simple as possible 🙂
Owner
There was a problem hiding this comment.
I'm working on the latter, I'll be pushing a commit soon.
Owner
|
Thanks for your PR @kernel-sanders. Everything else LGTM 👍 |
o2sh
approved these changes
Jan 10, 2021
kernel-sanders
commented
Jan 10, 2021
Contributor
Author
kernel-sanders
left a comment
kernel-sanders
left a comment
There was a problem hiding this comment.
Looks great! Moving the output logic into printers.rs cleans up main a bit as well.
spenserblack
approved these changes
Jan 10, 2021
Co-authored-by: Spenser Black <spenserblack01@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull adds a -y flag which enables YAML output as well as a -z flag that outputs dates in ISO 8601 format. I'm using this to populate data on repos for a personal project so if these features don't interest you, no worries!