Skip to content

Update event log fetching documentation and improve code consistency#105

Merged
mahabubAlahi merged 2 commits intodevelopfrom
update/events
Apr 17, 2026
Merged

Update event log fetching documentation and improve code consistency#105
mahabubAlahi merged 2 commits intodevelopfrom
update/events

Conversation

@mahabubAlahi
Copy link
Copy Markdown
Contributor

Summary

  • Removed unsafe fromBlock: 0n default from all 8 contract events.ts files. Previously, calling get*Logs() without options silently scanned from genesis (block 0), which times out or errors on public RPCs. Now omitting fromBlock queries only the latest block (viem's safe default).
  • Added RPC block range limit documentation to EventFilterOptions JSDoc and the README Events section, warning users that public RPCs (Forno, Infura free tier) restrict eth_getLogs to ~2,000–10,000 blocks per request.

@mahabubAlahi mahabubAlahi self-assigned this Apr 7, 2026
@mahabubAlahi mahabubAlahi added the enhancement New feature or request label Apr 7, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b818436d18

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread packages/contracts/src/contracts/all-or-nothing/events.ts
@mahabubAlahi mahabubAlahi merged commit b6547d7 into develop Apr 17, 2026
7 checks passed
@mahabubAlahi mahabubAlahi deleted the update/events branch April 22, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants