test(contracts): add comprehensive unit and integration test suite for @oaknetwork/contracts#82
Merged
tahseen-ccprotocol merged 4 commits intofeat/contract-sdkfrom Mar 30, 2026
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da2c509f38
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
mahabubAlahi
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@oaknetwork/contractspackagegetRecoveryHintinto its own module to enable accurate coverage measurementdotenv, coverage exclusions for barrel/ABI files, and separatetest:unit/test:integrationscriptsWhat changed
New test infrastructure
__tests__/setup/config.ts— Loads and strictly validates all required environment variables (RPC_URL,PRIVATE_KEY, contract addresses), throwing explicit errors if prerequisites are missing__tests__/setup/test-client.ts— SharedOakContractsClientfactory for integration tests.env.example— Documents the 9 required environment variables for running integration tests on Celo SepoliaUnit tests (10 files)
All reads are wrapped in try/catch to handle uninitialized implementation contracts gracefully. Writes and simulates are wrapped since they are expected to revert without proper on-chain state.
Source changes (non-behavioral)
src/errors/recovery.ts(new) — ExtractedgetRecoveryHintfromsrc/errors/index.tsso the barrel file is a pure re-exportsrc/errors/index.ts— Now re-exportsgetRecoveryHintfromrecovery.tssrc/errors/parse/*.ts— Restructured default branches in 8 error parsers with/* istanbul ignore next */on genuinely unreachable defensive fallbacks (no logic changes)Configuration
jest.config.cjs— Addeddotenv/configsetup, excluded barrel files (src/*/index.ts) and ABI files from coverage collectionpackage.json— Addedtest:unitandtest:integrationscripts; integration tests skip coverage thresholds; addeddotenvas a devDependencyTest plan
pnpm test:unit— all unit tests pass with 100% coveragepnpm test:integration— all 263 integration tests pass (requires.envwith Celo Sepolia addresses)pnpm test— full suite passes with 90%+ global coverage thresholdistanbul ignorecomments added