This repository was archived by the owner on Apr 14, 2026. It is now read-only.
Merged
Conversation
When libopenapi resolves a $ref, it copies extensions from the target component schema to the resolved proxy. This caused property-level refs (e.g., pagination: $ref Pagination) to inherit x-go-type from the target, which made the gatherer treat each ref site as a separate type-generating schema. Since all child schemas under the same response got the same operationId-based name, this produced duplicate type declarations that would not compile. Fix: skip extension checks and extension copying for reference schemas in gatherFromSchemaProxy(). Extensions belong to the component schema descriptor, not to every reference site that points to it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When libopenapi resolves a $ref, it copies extensions from the target component schema to the resolved proxy. This caused property-level refs (e.g., pagination: $ref Pagination) to inherit x-go-type from the target, which made the gatherer treat each ref site as a separate type-generating schema. Since all child schemas under the same response got the same operationId-based name, this produced duplicate type declarations that would not compile.
Fix: skip extension checks and extension copying for reference schemas in gatherFromSchemaProxy(). Extensions belong to the component schema descriptor, not to every reference site that points to it.