Enhance linting, testing setup, and LLM model handling#17
Merged
Conversation
- Updated ESLint configuration to include support for test files and added new globals for Jest. - Modified package.json to include test files in linting and added coverage thresholds. - Introduced a set of common stopwords in doc-extractor for better keyword extraction. - Refactored doc-patcher to implement retry logic for GitHub API calls. - Enhanced drift-detector to skip large document sections and handle LLM call errors gracefully. - Improved LLM client to truncate text at newlines and increased max tokens for API calls. - Added retry logic for PR commenting to handle potential API rate limits. - Created comprehensive tests for the main orchestration entry point, covering various scenarios and edge cases.
✅ Knowledge Diff — No Rationale Drift DetectedChecked 12 changed file(s) against 1 documentation file(s) — all clear. 🧠 knowledge-diff • analysed 17 candidate pair(s) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements across documentation, testing, workflows, and code quality. The most notable changes include expanded and more robust test coverage (including a new top-level integration test for the main entry point), improved linting and code quality enforcement (especially for test files), updates to workflow and template files for better usability and accuracy, and minor documentation and configuration adjustments.
Testing improvements:
index.test.tsfile to test the main orchestration entry point, mocking all major dependencies and verifying correct wiring and error handling. This significantly increases confidence in the integration of core components.LLMClientandDriftDetectorto handle additional edge cases, such as different Anthropic response formats, retry logic, and error handling in drift detection analysis. [1] [2]Linting and code quality:
__tests__/**/*.ts), added a dedicated config block for test environments, and allowed certain globals and relaxed some rules for test code. [1] [2] [3]lintnpm script now also checks test files, ensuring consistent code quality across the project.Workflow and template updates:
buglabel by default.npm citonpm installfor dependency installation, improving compatibility in some environments.Documentation and configuration:
README.mdfor accuracy, including revised token/cost calculations and an added lint command. [1] [2]package.jsonto enforce high test coverage.These changes collectively improve the project's reliability, maintainability, and usability.