feat: support pinning oasdiff CLI version in release.sh#90
Merged
reuvenharrison merged 1 commit intomainfrom Apr 11, 2026
Merged
feat: support pinning oasdiff CLI version in release.sh#90reuvenharrison merged 1 commit intomainfrom
reuvenharrison merged 1 commit intomainfrom
Conversation
Add an optional second argument [oasdiff-version] to release.sh. When provided, the script patches the FROM line in all four Dockerfiles (breaking, changelog, diff, pr-comment) and includes them in the release commit alongside the README bump. ./release.sh v0.0.38 v1.13.5 Without the argument the Dockerfiles are left unchanged, preserving backwards compatibility for action-only releases. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional second argument to
release.shso that each action release can atomically pin the oasdiff CLI image version used by all four Dockerfiles.FROM tufin/oasdiff:<current>→FROM tufin/oasdiff:v1.13.5in all four Dockerfiles (breaking/,changelog/,diff/,pr-comment/)chore: bump action to v0.0.38, pin oasdiff to v1.13.5Motivation
Follows from the review of #89: pinning by version tag is the right direction, but only sustainable if bumping the version is automated rather than a manual edit across four files.
Test plan
sedpatterns replace theFROMline correctly for both:stableand a pinned tag🤖 Generated with Claude Code