Skip to content

feat: support pinning oasdiff CLI version in release.sh#90

Merged
reuvenharrison merged 1 commit intomainfrom
feat/automate-oasdiff-version-bump
Apr 11, 2026
Merged

feat: support pinning oasdiff CLI version in release.sh#90
reuvenharrison merged 1 commit intomainfrom
feat/automate-oasdiff-version-bump

Conversation

@reuvenharrison
Copy link
Copy Markdown
Contributor

Summary

Adds an optional second argument to release.sh so that each action release can atomically pin the oasdiff CLI image version used by all four Dockerfiles.

./release.sh v0.0.38 v1.13.5
  • Patches FROM tufin/oasdiff:<current>FROM tufin/oasdiff:v1.13.5 in all four Dockerfiles (breaking/, changelog/, diff/, pr-comment/)
  • Includes the Dockerfiles in the same commit as the README bump, with an updated commit message: chore: bump action to v0.0.38, pin oasdiff to v1.13.5
  • Shows the current oasdiff version alongside the action version in the opening log line, so you can see at a glance what is changing
  • Without the second argument the script behaves exactly as before (backwards compatible)

Motivation

Follows from the review of #89: pinning by version tag is the right direction, but only sustainable if bumping the version is automated rather than a manual edit across four files.

Test plan

  • Dry-run: verify sed patterns replace the FROM line correctly for both :stable and a pinned tag
  • Smoke-run against a test branch to confirm the commit includes the Dockerfiles when the argument is provided and excludes them when it is not

🤖 Generated with Claude Code

Add an optional second argument [oasdiff-version] to release.sh.
When provided, the script patches the FROM line in all four Dockerfiles
(breaking, changelog, diff, pr-comment) and includes them in the release
commit alongside the README bump.

  ./release.sh v0.0.38 v1.13.5

Without the argument the Dockerfiles are left unchanged, preserving
backwards compatibility for action-only releases.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@reuvenharrison reuvenharrison merged commit e6faebc into main Apr 11, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant