Skip to content
This repository was archived by the owner on Oct 6, 2021. It is now read-only.
This repository was archived by the owner on Oct 6, 2021. It is now read-only.

ethereum: Rollup includes browser ethers.js for node #118

@armaniferrante

Description

@armaniferrante

When building the ethereum package for node with rollup, we're including the browser field. See https://github.com/oasislabs/oasis-client/blob/master/packages/ethereum/rollup/rollup.config.ts#L35. This causes:

$ jest test/e2e
  console.log ../ethereum/dist/index.umd.js:8723
    WARNING: Missing strong random number source; using weak randomBytes

  console.log ../ethereum/dist/index.umd.js:8723
    Warning: XMLHttpRequest is not defined

We should obviously change this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    p:1Priority: core features:blockedStatus: blocked on other work

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions