rofl/build: Fix concat #660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-cli canceled.
|
Member
Author
|
Now the issue is if the container has more permissions than the user (ie root) :) since we still read from the host in some places. Actually the right fix is to keep the FixPermissions, but fix it when run in container. |
ptrus
force-pushed
the
ptrus/feature/rootless-containers-fixes
branch
from
ae13b12 to
2d77e20
Compare
ptrus
changed the title
ptrus
force-pushed
the
ptrus/feature/rootless-containers-fixes
branch
from
2d77e20 to
8fb43c8
Compare
Member
Author
|
@matevz please try again on latest version when you'll have the time |
peternose
reviewed
Dec 15, 2025
ptrus
force-pushed
the
ptrus/feature/rootless-containers-fixes
branch
from
8fb43c8 to
209907c
Compare
peternose
approved these changes
Dec 15, 2025
ptrus
force-pushed
the
ptrus/feature/rootless-containers-fixes
branch
from
209907c to
9aac458
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.