build: Fix missing eq function in version computation #661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-cli canceled.
|
ptrus
force-pushed
the
ptrus/fix/version-eq
branch
from
de63e87 to
ad06fdf
Compare
peternose
approved these changes
Dec 15, 2025
matevz
approved these changes
Dec 15, 2025
Member
matevz
left a comment
matevz
left a comment
There was a problem hiding this comment.
This code is mostly from the oasis-node release process. Can you check if there are any issues there too?
Member
Author
No, But the |
Member
Author
|
Updated the comment to be consistent with the one in oasis-core. |
ptrus
force-pushed
the
ptrus/fix/version-eq
branch
from
ad06fdf to
82d834a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
eqfunction was used incommon.mkbut never defined, causingVERSIONto always append-git<commit>even when building from an exact tag.cli/common.mk
Line 55 in 1323206
Also fix
+dirtysuffix to be added in case of uncommitted changes on the exact tag.