Simplify hover highlight v2 (keep the border) #2182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
This was referenced Sep 4, 2025
Contributor
Author
|
Decision from @donouwens:
So, this PR is the one that survives the culling. |
csillag
force-pushed
the
csillag/simplify-hover-highlight-but-keep-border
branch
from
ad34efb to
04a144f
Compare
lubej
approved these changes
Sep 4, 2025
src/app/components/HoverHighlightingContext/WithHoverHighlighting.tsx
Outdated
Show resolved
Hide resolved
Earlier we had some difficulty about padding/margin about addresses that we might want to highlight on hover, because we wanted a bubble around the highlighted part. Unfortunately this makes correct spacing next to impossible, so now we are giving it up. From now, hover highlight will simply change the background, and nothing else. This makes all workaround unnecessary. Also, fix some more vertical alignment issues around links, so that everything lines up nicely.
- Always use "whatever" for props, instead of {'whatever'}
csillag
force-pushed
the
csillag/simplify-hover-highlight-but-keep-border
branch
from
04a144f to
157d0e5
Compare
csillag
restored the
csillag/simplify-hover-highlight-but-keep-border
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternate implementation of #2178, which keeps the border around the hover highlight, at the cost of losing one pixel around every address, and 1px of misalignment.
See screenshots at #2178.