Simplify hover highlight v3 (keep the border and -1px horizontal margin) #2183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier we had some difficulty about padding/margin about addresses that we might want to highlight on hover, because we wanted a bubble around the highlighted part. Unfortunately this makes correct spacing next to impossible, so now we are giving it up. From now, hover highlight will simply change the background, and nothing else. This makes all workaround unnecessary. Also, fix some more vertical alignment issues around links, so that everything lines up nicely.
Deployed to Cloudflare Pages
|
csillag
changed the title
Contributor
Author
|
Decision from @donouwens:
So, I'm closing this (v3) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternate implementation of #2178 and #2182, which keeps the border around the hover highlight, but adds 1px of negative horizontal margin. This means that we will have proper vertical alignment, but use one pixel above and below every address. We might see some clipping at the left and right sides, if the address is squeezed somewhere really tightly. (I haven't seen this manifest anywhere yet.)
See screenshots at #2178.