Skip to content

Display Contract ByteCode#616

Merged
csillag merged 8 commits into
masterfrom
csillag/more-account-details
Jun 29, 2023
Merged

Display Contract ByteCode#616
csillag merged 8 commits into
masterfrom
csillag/more-account-details

Conversation

@csillag
Copy link
Copy Markdown
Contributor

@csillag csillag commented Jun 28, 2023

For accounts, we should be able to display contract bytecode, if available.

Designs:

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 28, 2023

Deployed to Cloudflare Pages

Latest commit: 9e2a2174abcd94cc02c64cd584d979954d03ec10
Status:✅ Deploy successful!
Preview URL: https://00d686c5.oasis-explorer.pages.dev

@csillag csillag force-pushed the csillag/more-account-details branch 6 times, most recently from 45c748c to c094342 Compare June 29, 2023 01:03
@csillag csillag changed the title Display Token Transfers and Contract Code Display Contract Code Jun 29, 2023
@csillag csillag force-pushed the csillag/more-account-details branch from c094342 to f29c339 Compare June 29, 2023 01:05
@csillag csillag changed the title Display Contract Code Display Contract ByteCode Jun 29, 2023
@csillag csillag force-pushed the csillag/more-account-details branch from f29c339 to 36e9cc0 Compare June 29, 2023 01:06
@csillag csillag marked this pull request as ready for review June 29, 2023 01:07
@csillag
Copy link
Copy Markdown
Contributor Author

csillag commented Jun 29, 2023

@donouwens says:

Looks all good to me

@csillag
Copy link
Copy Markdown
Contributor Author

csillag commented Jun 29, 2023

This is now ready for review. I suggest going commit by commit.

@csillag csillag requested review from buberdds and lukaw3d June 29, 2023 05:48
Comment thread src/app/components/CopyToClipboard/index.tsx Outdated
Comment thread src/locales/en/translation.json
Comment thread src/locales/en/translation.json
Comment thread src/app/pages/AccountDetailsPage/ContractCodeCard.tsx Outdated
Comment thread src/app/pages/AccountDetailsPage/ContractCodeCard.tsx Outdated
Comment thread src/app/components/ScrollingDataDisplay/index.tsx
Comment thread src/app/components/ScrollingDataDisplay/index.tsx Outdated
Comment thread src/app/components/ScrollingDataDisplay/index.tsx Outdated
Comment thread src/app/components/ScrollingDataDisplay/index.tsx
Comment thread src/app/components/ScrollingDataDisplay/index.tsx Outdated
@csillag csillag force-pushed the csillag/more-account-details branch 3 times, most recently from 8d9cab1 to 28f9083 Compare June 29, 2023 12:13
@csillag csillag force-pushed the csillag/more-account-details branch 2 times, most recently from b775cc3 to 9c99634 Compare June 29, 2023 12:20
@csillag csillag requested a review from buberdds June 29, 2023 12:20
Comment thread src/app/pages/AccountDetailsPage/ContractCodeCard.tsx Outdated
@csillag csillag force-pushed the csillag/more-account-details branch from 9c99634 to 9e2a217 Compare June 29, 2023 12:35
@csillag csillag merged commit 7b6a060 into master Jun 29, 2023
@csillag csillag deleted the csillag/more-account-details branch June 29, 2023 12:37
Comment thread src/app/components/ParaTimePicker/LayerMenu.tsx
Comment thread src/app/components/ScrollingDataDisplay/index.tsx
Comment thread src/app/pages/AccountDetailsPage/ContractCodeCard.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants