Prefer string literals instead of enum constants #2016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/use-string-literals
branch
from
6dab615 to
6d45871
Compare
lukaw3d
changed the title
csillag
force-pushed
the
csillag/use-string-literals
branch
from
6d45871 to
b220d7f
Compare
lukaw3d
approved these changes
Jun 11, 2025
Member
|
@buberdds, is this approach of using string literals also good with you? |
csillag
force-pushed
the
csillag/use-string-literals
branch
from
b220d7f to
204f42c
Compare
csillag
force-pushed
the
csillag/use-string-literals
branch
from
204f42c to
51ef949
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #2002, where @lukaw3d commented:
So, this PR increases the usage of string literals, instead of
LayerandNetworkconstants.So,
Network.mainnet=>'mainnet'Layer.sapphire=>'sapphire'etc.