Skip to content

home: Remove / in redirects#192

Merged
lubej merged 1 commit intomasterfrom
ml/remove-slash-in-redirects
Feb 10, 2025
Merged

home: Remove / in redirects#192
lubej merged 1 commit intomasterfrom
ml/remove-slash-in-redirects

Conversation

@lubej
Copy link
Collaborator

@lubej lubej commented Feb 10, 2025

Due to how analytics collects paths, there are now 2 entries for some of the entries, like /discover and /discover/. Other possible way to fix this would be to modify the submitted url in FathomAnalytics.tsx(in case it ends with slash, remove it).

@github-actions
Copy link

github-actions bot commented Feb 10, 2025

Deployed to Cloudflare Pages

Latest commit: 4f69540f9402dbd7c24715285773df5126d9c87a
Status:✅ Deploy successful!
Preview URL: https://8ee8b159.rose-app.pages.dev
Alias: https://pr-192.rose-app.pages.dev

@cloudflare-workers-and-pages
Copy link

Deploying rose-app with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4f69540
Status: ✅  Deploy successful!
Preview URL: https://8ee8b159.rose-app.pages.dev
Branch Preview URL: https://pr-192.rose-app.pages.dev

View logs

@lubej lubej self-assigned this Feb 10, 2025
Copy link
Contributor

@buberdds buberdds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have a feeling that we will need FathomAnalytics updates too in the future

@lubej
Copy link
Collaborator Author

lubej commented Feb 10, 2025

have a feeling that we will need FathomAnalytics updates too in the future

I think that the events originated from redirects, will see if they continue to accumulate in analytics.

@lubej lubej merged commit 6991446 into master Feb 10, 2025
5 checks passed
@lubej lubej deleted the ml/remove-slash-in-redirects branch February 10, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants