Skip to content

Move balance into the same row as Manage button on mobile#1838

Merged
lukaw3d merged 3 commits intomasterfrom
lw/balance-mobile
Jan 25, 2024
Merged

Move balance into the same row as Manage button on mobile#1838
lukaw3d merged 3 commits intomasterfrom
lw/balance-mobile

Conversation

@lukaw3d
Copy link
Copy Markdown
Contributor

@lukaw3d lukaw3d commented Jan 25, 2024

Includes #1837

Before After
localhost_3000_account_oasis1qpp0gmh4fug8qnrz8ca233nmvxqlcw6vechczper(iPhone XR) localhost_3000_account_oasis1qpp0gmh4fug8qnrz8ca233nmvxqlcw6vechczper(iPhone XR) (1)

@lukaw3d lukaw3d requested a review from buberdds January 25, 2024 16:01
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 25, 2024

Deployed to Cloudflare Pages

Latest commit: db51c9c291a7b9cd8a6a166dd275fcc854c5bcb9
Status:✅ Deploy successful!
Preview URL: https://093c16f2.oasis-wallet.pages.dev

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 25, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6491e23) 81.17% compared to head (69901e2) 81.16%.
Report is 1 commits behind head on master.

❗ Current head 69901e2 differs from pull request most recent head db51c9c. Consider uploading reports for the commit db51c9c to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1838      +/-   ##
==========================================
- Coverage   81.17%   81.16%   -0.02%     
==========================================
  Files         192      192              
  Lines        5067     5064       -3     
  Branches      932      933       +1     
==========================================
- Hits         4113     4110       -3     
  Misses        954      954              
Flag Coverage Δ
cypress 46.13% <78.57%> (-0.08%) ⬇️
jest 76.97% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...pp/components/Toolbar/Features/Account/Account.tsx 93.18% <81.25%> (-0.30%) ⬇️

... and 2 files with indirect coverage changes

@lukaw3d lukaw3d enabled auto-merge January 25, 2024 20:32
@lukaw3d lukaw3d merged commit a59f787 into master Jan 25, 2024
@lukaw3d lukaw3d deleted the lw/balance-mobile branch January 25, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants