Conversation
Contributor
lukaw3d
commented
Jan 25, 2024
lukaw3d
commented
| Before | After |
|---|---|
 |
 |
Deployed to Cloudflare Pages
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1837 +/- ##
==========================================
+ Coverage 81.13% 81.17% +0.03%
==========================================
Files 192 192
Lines 5058 5067 +9
Branches 932 932
==========================================
+ Hits 4104 4113 +9
Misses 954 954
Flags with carried forward coverage won't be shown. Click here to find out more.
|
buberdds
approved these changes
Jan 25, 2024
| export const Account = memo((props: AccountProps) => { | ||
| const { t } = useTranslation() | ||
| const size = useContext(ResponsiveContext) | ||
| const [isHovering, setIsHovering] = useState(false) |
Contributor
There was a problem hiding this comment.
button with a hover effect looks a bit weird without horizontal padding
Contributor
Author
There was a problem hiding this comment.
do you mean the inner Manage button?
(this line is for whole address + manage + balance)
lukaw3d
force-pushed
the
lw/manage-acc-btn
branch
from
367609a to
ddf6dfe
Compare
added 4 commits
January 25, 2024 21:20
Box.hoverIndicator is implemented with simple `:hover` and does not call backgroundIsDark nor use StyledManageButton.color.light like it does when we switch background on isActive.
lukaw3d
force-pushed
the
lw/manage-acc-btn
branch
from
ddf6dfe to
6491e23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.