Skip to content

Fix initial load for pending txs on account page#1998

Merged
lubej merged 1 commit intomasterfrom
ml/fix-initial-load-for-pending-txs-on-account-page
Jul 10, 2024
Merged

Fix initial load for pending txs on account page#1998
lubej merged 1 commit intomasterfrom
ml/fix-initial-load-for-pending-txs-on-account-page

Conversation

@lubej
Copy link
Copy Markdown
Contributor

@lubej lubej commented Jul 10, 2024

Description

Closes #1997
showPendingSection was "wrongly" evaluated, as it was changing on account loading state. Introduce new variable, that correctly takes into account initial loading state.

Links

https://www.loom.com/share/cda0241c8eaf4c21b20391aba69d3609

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 10, 2024

Deployed to Cloudflare Pages

Latest commit: b0eff3abbdf51789bcdb6a65c15b705282be1284
Status:✅ Deploy successful!
Preview URL: https://f1afc509.oasis-wallet.pages.dev

@lubej lubej force-pushed the ml/fix-initial-load-for-pending-txs-on-account-page branch from 0144c03 to b0eff3a Compare July 10, 2024 08:26
@lubej lubej requested review from buberdds and lukaw3d July 10, 2024 08:29
@lubej lubej marked this pull request as ready for review July 10, 2024 10:50
@lubej lubej merged commit 5cde5dd into master Jul 10, 2024
@lubej lubej deleted the ml/fix-initial-load-for-pending-txs-on-account-page branch July 10, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pending transactions screen "flashes" during transaction loading

2 participants