Allow new access token class inheriting from AccessToken class to get access token instance of the its own class when refreshed #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styd
force-pushed
the
extending-access-token-class
branch
from
46e67f5 to
96daaf5
Compare
styd
changed the title
3 similar comments
Member
|
@styd If you get a chance please rebase this on master. We've improved many things in the codebase, and the CI build is now functional, and passing. |
…s token instance of the its own class when refreshed
styd
force-pushed
the
extending-access-token-class
branch
from
d21ab69 to
9f08416
Compare
Contributor
Author
|
@pboling I've rebased it on master. Please review. Thanks. |
meganemura
suggested changes
Oct 14, 2018
Contributor
meganemura
left a comment
meganemura
left a comment
There was a problem hiding this comment.
Great update. I will close #425.
This branch needs to update some points.
lib/oauth2/access_token.rb
Outdated
| # @return [AccessToken] a new AccessToken | ||
| # @note options should be carried over to the new AccessToken | ||
| def refresh(params = {}) | ||
| def refresh!(params = {}, access_token_opts = {}, access_token_class = self.class) |
Contributor
There was a problem hiding this comment.
This must be refresh, not refresh! since it was renamed.
spec/oauth2/access_token_spec.rb
Outdated
| :param_name => 'o_param') | ||
| end | ||
| let(:new_access) do | ||
| NewAccessToken = Class.new(AccessToken) |
Contributor
There was a problem hiding this comment.
This will be notified by RuboCop.
Use described_class instead of AccessToken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new class inherits from the AccessToken class, its refresh! method should return an instance of its own class, not of AccessToken's.