Upgrade rubocop to version 0.58.2 #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pboling
added
in Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've upgraded a dependency and all tests pass. \o/
You should probably take a good look at this before merging this pull request, of course.
What changed?
✳️ rubocop ( → 0.58.2) · Repo · Changelog
Release Notes
From the Github release:
Changes
New features
#6105: Support
{a,b}file name globs inExcludeandIncludeconfig. (@mikeyhew)#6116: Add
ipto allowed names ofNaming/UncommunicativeMethodParamNamecop in default config. (@nijikon)Bug fixes
Layout/IndentationWidthwhen multiple modifiers are used in a block and a method call is made at end of the block. (@koic)Naming/MemoizedInstanceVariableNamecop to allow methods to have leading underscores. (@kenman345)Layout/ClassStructurewhen there is a comment in the macro method to be auto-correct. (@koic)Lint/OrderedMagicCommentswhen using{ encoding: Encoding::SJIS }hash object afterfrozen_string_literalmagic comment. (@koic)Commits
See the full diff on Github. The new version differs by 19 commits:
Cut 0.58.2Make `MagicComment` aware of indented Ruby's magic comments[Fix #6115] Fix a false positive for `Lint/OrderedMagicComments`Add a favicon to the manualMerge pull request #6120 from jaredbeck/remove_redundant_ru_defaultRemove redundant Include of config.ru in default.ymlMerge pull request #6118 from pocke/cache-keyRemove `pwd` from cache key[Fix #6105] Support `{a,b}` glob patterns in PathUtilAllow `ip` as method parameter in default configUpdate doc of `Rails/LexicallyScopedActionFilter`[Fix #6098] Fix an error for `Layout/ClassStructure`Restore tests for Ruby 2.1 or higherFix a false positive for `Layout/IndentationWidth` (#6103)[Fix #6084] Allow leading underscores for method names (#6095)[Fix #6079] Update a documentation for `Lint/ShadowedArgument` cop (#6096)Add Pronto to Automated Code Review sectionDrop min target Ruby version from `Lint/UnneededRequireStatement`Extend the README a bitDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.