Skip to content

Use Base64.strict_encode64 #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 5, 2018
Merged

Use Base64.strict_encode64 #414

merged 2 commits into from
Oct 5, 2018

Conversation

@meganemura
Copy link
Contributor

@meganemura meganemura commented Oct 4, 2018

This is a successor of #325.

@meganemura
Copy link
Contributor Author

meganemura commented Oct 4, 2018

@josephpage @pboling Would you please review this?

@coveralls
Copy link

coveralls commented Oct 4, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 709

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%
Totals Coverage Status
Change from base Build 706: 0.0%
Covered Lines:
Relevant Lines: 0
💛 - Coveralls

10 similar comments
@coveralls
Copy link

coveralls commented Oct 4, 2018

Pull Request Test Coverage Report for Build 709

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%
Totals Coverage Status
Change from base Build 706: 0.0%
Covered Lines:
Relevant Lines: 0
💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 4, 2018

Pull Request Test Coverage Report for Build 709

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%
Totals Coverage Status
Change from base Build 706: 0.0%
Covered Lines:
Relevant Lines: 0
💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 4, 2018

Pull Request Test Coverage Report for Build 709

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%
Totals Coverage Status
Change from base Build 706: 0.0%
Covered Lines:
Relevant Lines: 0
💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 4, 2018

Pull Request Test Coverage Report for Build 709

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%
Totals Coverage Status
Change from base Build 706: 0.0%
Covered Lines:
Relevant Lines: 0
💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 4, 2018

Pull Request Test Coverage Report for Build 709

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%
Totals Coverage Status
Change from base Build 706: 0.0%
Covered Lines:
Relevant Lines: 0
💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 4, 2018

Pull Request Test Coverage Report for Build 709

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%
Totals Coverage Status
Change from base Build 706: 0.0%
Covered Lines:
Relevant Lines: 0
💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 4, 2018

Pull Request Test Coverage Report for Build 709

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%
Totals Coverage Status
Change from base Build 706: 0.0%
Covered Lines:
Relevant Lines: 0
💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 4, 2018

Pull Request Test Coverage Report for Build 709

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%
Totals Coverage Status
Change from base Build 706: 0.0%
Covered Lines:
Relevant Lines: 0
💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 4, 2018

Pull Request Test Coverage Report for Build 709

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%
Totals Coverage Status
Change from base Build 706: 0.0%
Covered Lines:
Relevant Lines: 0
💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 4, 2018

Pull Request Test Coverage Report for Build 709

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%
Totals Coverage Status
Change from base Build 706: 0.0%
Covered Lines:
Relevant Lines: 0
💛 - Coveralls

@pboling pboling added this to the 3.0.0 milestone Oct 5, 2018
@pboling pboling added the DO NOT MERGE Do. Not. Merge. label Oct 5, 2018
@pboling
Copy link
Member

pboling commented Oct 5, 2018

I need to review this for breaking changes.

We are not dropping any existing support for old Rubies in the 2.0.0 release.

# Base64.strict_encode64 is not available on Ruby 1.8.7

This might need to go into the follow up 3.0.0 release.

@meganemura
Copy link
Contributor Author

meganemura commented Oct 5, 2018

@pboling

In https://github.com/oauth-xx/oauth2/milestone/1 and #325,

2.x is the last version series that will have Ruby 1.9/2.0/2.1/2.2 support.

So, I think 2.x release does not need to support ruby 1.8.

@pboling
Copy link
Member

pboling commented Oct 5, 2018

Oh good point! I need to add a Ruby support matrix to the Readme.

@pboling pboling removed the DO NOT MERGE Do. Not. Merge. label Oct 5, 2018
@pboling pboling modified the milestones: 3.0.0, 2.0.0 Oct 5, 2018
@pboling pboling self-assigned this Oct 5, 2018
@pboling pboling self-requested a review October 5, 2018 22:12
pboling
pboling approved these changes Oct 5, 2018
View reviewed changes
Copy link
Member

@pboling pboling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@pboling pboling merged commit 5436fa3 into ruby-oauth:master Oct 5, 2018
@pboling pboling mentioned this pull request Oct 5, 2018
Closed
@meganemura meganemura deleted the strict_encode64 branch October 6, 2018 00:49
@pboling pboling added the in Changelog Has been added to Changelog label Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pboling pboling pboling approved these changes

Assignees

@pboling pboling

Labels

in Changelog Has been added to Changelog

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@meganemura @coveralls @pboling @escoberik