Skip to content

Conversation

@mjsalinger
Copy link
Contributor

No description provided.

@mjsalinger mjsalinger requested a review from maxtruxa August 9, 2017 11:20
@mjsalinger mjsalinger changed the title V3.0.0 release V3.0.0 release proposal Aug 9, 2017
@mjsalinger
Copy link
Contributor Author

@maxtruxa @andrewmaillet Can either of you take a quick look?


* `generateAccessToken(client, user, scope)` is **optional** and should return a _String.
* `generateAccessToken(client, user, scope)` is **optional** and should return a `String`.
* `generateAuthorizationCode()` is **optional** and should return a _String.
Copy link
Contributor

@andrewmaillet andrewmaillet Aug 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should _String be backtick quoted like the others?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@mjsalinger mjsalinger merged commit e1f741f into oauthjs:master Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants